diff options
| author |   Silvan Jegen <[email protected]>
| 2024-12-20 23:11:22 +0100 |
|---|---|---|
| committer |   Simon Ser <[email protected]>
| 2024-12-20 23:17:08 +0100 |
| commit | e50745066a375a18e25fd1b0b14f6cfa1df30814 (patch) | |
| tree | d333f227bae2658b2feefc3871323d3735c4b376 | |
| parent | 29cc111962100efa65183d6fa636399c8bb5651f (diff) | |
| download | alps-e50745066a375a18e25fd1b0b14f6cfa1df30814.tar.gz alps-e50745066a375a18e25fd1b0b14f6cfa1df30814.tar.bz2 alps-e50745066a375a18e25fd1b0b14f6cfa1df30814.zip | |
plugins/base/routes: fix err variable shadowing
Redeclaring the same variable shadows the outer one. This means the
error check below will never check this error.
This issue was found with golangci-lint.
Signed-off-by: Silvan Jegen <[email protected]>
| -rw-r--r-- | plugins/base/routes.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/plugins/base/routes.go b/plugins/base/routes.go index 10b30c1..623a5cc 100644 --- a/plugins/base/routes.go +++ b/plugins/base/routes.go @@ -857,8 +857,8 @@ func populateMessageFromOriginalMessage(ctx *alps.Context, inReplyToPath message ret.Text, err = quote(strings.NewReader(text)) default: - err := fmt.Errorf("cannot forward %q part", mimeType) - err = echo.NewHTTPError(http.StatusBadRequest, err) + defErr := fmt.Errorf("cannot forward %q part", mimeType) + err = echo.NewHTTPError(http.StatusBadRequest, defErr) } if err != nil { return ret, err @@ -944,8 +944,8 @@ func handleForward(ctx *alps.Context) error { msg.Text, err = quote(strings.NewReader(text)) default: - err := fmt.Errorf("cannot forward %q part", mimeType) - err = echo.NewHTTPError(http.StatusBadRequest, err) + defErr := fmt.Errorf("cannot forward %q part", mimeType) + err = echo.NewHTTPError(http.StatusBadRequest, defErr) } if err != nil { return err |